yadunut/clan-core
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix: remove password from facts store tests

Browse Source
This commit is contained in:
Johannes Kirschbauer
2025-01-14 14:52:41 +01:00
parent 14261b8a8c
commit f16f68c77b
2 changed files with 20 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
pkgs/clan-cli/tests/test_secrets_generate.py
View File

@@ -81,8 +81,26 @@ def test_generate_secret(
Machine(name="vm2", flake=FlakeId(str(test_flake_with_core.path)))
)
assert store2.exists("", "password")
assert store2.exists("", "password-hash")
# Should not exist clan facts generate
assert not store2.exists("", "password")
assert not store2.exists("", "password-hash")
# clan vars generate
# TODO: Test vars
# varsStore = VarsSecretStore(
# machine=Machine(name="vm2", flake=FlakeId(str(test_flake_with_core.path)))
# )
# generators = get_generators(str(test_flake_with_core.path), "vm2")
# generator = next((gen for gen in generators if gen.name == "root-password"), None)
# if not generator:
# raise Exception("Generator not found")
# password_update = GeneratorUpdate(
# generator=generator.name, prompt_values={"password": "1234"}
# )
# set_prompts(str(test_flake_with_core.path), "vm2", [password_update])
# assert varsStore.exists(generator, "root-password")
assert store2.exists("", "user-password")
assert store2.exists("", "user-password-hash")
assert store2.exists("", "age.key")
@@ -96,14 +114,6 @@ def test_generate_secret(
assert age_secret.isprintable()
assert is_valid_age_key(age_secret)
# Assert that root-password is valid
pwd_secret = store2.get("", "password").decode()
assert pwd_secret.isprintable()
assert pwd_secret.isascii()
pwd_hash = store2.get("", "password-hash").decode()
assert pwd_hash.isprintable()
assert pwd_hash.isascii()
# Assert that user-password is valid
pwd_secret = store2.get("", "user-password").decode()
assert pwd_secret.isprintable()

8
pkgs/clan-cli/tests/test_secrets_password_store.py
View File

@@ -93,14 +93,6 @@ def test_upload_secret(
assert not store.exists("", "password")
assert not store.exists("", "password-hash")
# Assert that root-password is valid
# pwd_secret = store.get("", "password").decode()
# assert pwd_secret.isprintable()
# assert pwd_secret.isascii()
# pwd_hash = store.get("", "password-hash").decode()
# assert pwd_hash.isprintable()
# assert pwd_hash.isascii()
# Assert that user-password is valid
pwd_secret = store.get("", "user-password").decode()
assert pwd_secret.isprintable()