yadunut/clan-core
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

facts: don't swallow exceptions when running clan facts generate

Browse Source
This commit is contained in:
Michael Hoang
2024-12-11 16:40:49 +11:00
parent feadae816c
commit a876a5d6f4
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkgs/clan-cli/clan_cli/facts/generate.py
View File

@@ -3,6 +3,7 @@ import importlib
import logging import logging
import os import os
import sys import sys
import traceback
from collections.abc import Callable from collections.abc import Callable
from pathlib import Path from pathlib import Path
from tempfile import TemporaryDirectory from tempfile import TemporaryDirectory
@@ -202,8 +203,9 @@ def generate_facts(
was_regenerated |= _generate_facts_for_machine( was_regenerated |= _generate_facts_for_machine(
machine, service, regenerate, tmpdir, prompt machine, service, regenerate, tmpdir, prompt
) )
except (OSError, ClanError): except (OSError, ClanError) as e:
machine.error("Failed to generate facts") machine.error(f"Failed to generate facts: {e}")
traceback.print_exc()
errors += 1 errors += 1
if errors > 0: if errors > 0:
msg = ( msg = (