From a876a5d6f494d4729424e0559ee6a78c60897960 Mon Sep 17 00:00:00 2001 From: Michael Hoang Date: Wed, 11 Dec 2024 16:40:49 +1100 Subject: [PATCH] facts: don't swallow exceptions when running `clan facts generate` --- pkgs/clan-cli/clan_cli/facts/generate.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pkgs/clan-cli/clan_cli/facts/generate.py b/pkgs/clan-cli/clan_cli/facts/generate.py index 19bcead3d..39eaa258c 100644 --- a/pkgs/clan-cli/clan_cli/facts/generate.py +++ b/pkgs/clan-cli/clan_cli/facts/generate.py @@ -3,6 +3,7 @@ import importlib import logging import os import sys +import traceback from collections.abc import Callable from pathlib import Path from tempfile import TemporaryDirectory @@ -202,8 +203,9 @@ def generate_facts( was_regenerated |= _generate_facts_for_machine( machine, service, regenerate, tmpdir, prompt ) - except (OSError, ClanError): - machine.error("Failed to generate facts") + except (OSError, ClanError) as e: + machine.error(f"Failed to generate facts: {e}") + traceback.print_exc() errors += 1 if errors > 0: msg = (