vms: don't leak vsock sockets in error case

2024-12-11 16:49:03 +01:00
parent 0a3e49ba11
commit 13e72c7dbb
1 changed files with 2 additions and 3 deletions
--- a/pkgs/clan-cli/clan_cli/vms/waypipe.py
+++ b/pkgs/clan-cli/clan_cli/vms/waypipe.py
@@ -16,9 +16,8 @@ def test_vsock_port(port: int) -> bool:
        msg = "vsock is only supported on Linux"
        raise NotImplementedError(msg)
    try:
-        s = socket.socket(socket.AF_VSOCK, socket.SOCK_STREAM)
-        s.connect((VMADDR_CID_HYPERVISOR, port))
-        s.close()
+        with socket.socket(socket.AF_VSOCK, socket.SOCK_STREAM) as s:
+            s.connect((VMADDR_CID_HYPERVISOR, port))
    except OSError:
        return False
    else: