From 13e72c7dbbeb330abedce11f1f907b9819d49f07 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Thalheim?= Date: Wed, 11 Dec 2024 16:49:03 +0100 Subject: [PATCH] vms: don't leak vsock sockets in error case --- pkgs/clan-cli/clan_cli/vms/waypipe.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pkgs/clan-cli/clan_cli/vms/waypipe.py b/pkgs/clan-cli/clan_cli/vms/waypipe.py index c7b5216dc..524b65f99 100644 --- a/pkgs/clan-cli/clan_cli/vms/waypipe.py +++ b/pkgs/clan-cli/clan_cli/vms/waypipe.py @@ -16,9 +16,8 @@ def test_vsock_port(port: int) -> bool: msg = "vsock is only supported on Linux" raise NotImplementedError(msg) try: - s = socket.socket(socket.AF_VSOCK, socket.SOCK_STREAM) - s.connect((VMADDR_CID_HYPERVISOR, port)) - s.close() + with socket.socket(socket.AF_VSOCK, socket.SOCK_STREAM) as s: + s.connect((VMADDR_CID_HYPERVISOR, port)) except OSError: return False else: