k3s: some module cleanup

modules/nixos/my_k3s/default.nix

@@ -5,7 +5,6 @@
   ...
 }:
 let
-  cfg = config.my_k3s;
   inherit (lib)
     mkEnableOption
     mkIf
@@ -21,8 +20,11 @@ in
       type = types.nonEmptyStr;
     };
     role = mkOption {
-      type = types.nonEmptyStr;
+      type = types.enum [
-      default = "server";
+        "server"
+        "agent"
+      ];
+      default = "agent";
     };
     clusterInit = mkOption {
       type = types.bool;
@@ -32,6 +34,12 @@ in
       type = types.nonEmptyStr;
       default = "server";
     };
+    nodeIp = mkOption {
+      type = types.nonEmptyStr;
+    };
+    iface = mkOption {
+      type = types.nonEmptyStr;
+    };
     extraFlags = mkOption {
       type = types.listOf types.str;
       default = [ ];
@@ -40,18 +48,26 @@ in
       type = types.bool;
       default = false;
     };
-
   };
 
-  config = mkIf cfg.enable (mkMerge [
+  config =
+    let
+      cfg = config.my_k3s;
+      is_server = cfg.role == "server";
+    in
+    mkIf cfg.enable (mkMerge [
       {
         services.k3s = {
           enable = true;
           role = cfg.role;
           tokenFile = cfg.tokenFile;
-        clusterInit = cfg.clusterInit;
+          clusterInit = is_server && cfg.clusterInit;
           serverAddr = cfg.serverAddr;
-        extraFlags = cfg.extraFlags;
+          extraFlags = [
+            "--node-ip ${cfg.nodeIp}"
+            "--flannel-iface ${cfg.iface}"
+          ]
+          ++ cfg.extraFlags;
         };
         environment.systemPackages = [ pkgs.nfs-utils ];
         services.openiscsi = {
@@ -65,13 +81,7 @@ in
       (mkIf cfg.nvidia {
         hardware.nvidia-container-toolkit.enable = true;
         hardware.nvidia-container-toolkit.mount-nvidia-executables = true;
-      # virtualisation.docker = {
+        environment.systemPackages = [ pkgs.nvidia-container-toolkit ];
-      #   enable = true;
-      #   enableNvidia = true;
-      # };
-      environment.systemPackages = with pkgs; [
-        nvidia-container-toolkit
-      ];
       })
     ]);
 }

systems/x86_64-linux/penguin/default.nix

@@ -37,10 +37,8 @@ in
       tokenFile = config.age.secrets.k3s.path;
       clusterInit = false;
       serverAddr = "https://10.222.0.13:6443";
-      extraFlags = [
+      nodeIp = "10.222.0.249";
-        "--node-ip 10.222.0.249"
+      iface = "ztxh6lvd6t";
-        "--flannel-iface ztxh6lvd6t"
-      ];
       nvidia = true;
     };
     networking.hostName = "penguin";