From f3873683cc8f0173ae26a16adfbf007284c86252 Mon Sep 17 00:00:00 2001
From: Qubasa <consulting@qube.email>
Date: Thu, 10 Jul 2025 14:20:02 +0700
Subject: [PATCH] clan_lib: Add test for check_valid_clan function

---
 .../clan_cli/tests/fixtures_flakes.py         |  3 ++-
 pkgs/clan-cli/clan_lib/clan/check_test.py     | 22 +++++++++++++++++++
 2 files changed, 24 insertions(+), 1 deletion(-)
 create mode 100644 pkgs/clan-cli/clan_lib/clan/check_test.py

diff --git a/pkgs/clan-cli/clan_cli/tests/fixtures_flakes.py b/pkgs/clan-cli/clan_cli/tests/fixtures_flakes.py
index 59667d2f3..fe1136b0d 100644
--- a/pkgs/clan-cli/clan_cli/tests/fixtures_flakes.py
+++ b/pkgs/clan-cli/clan_cli/tests/fixtures_flakes.py
@@ -71,8 +71,8 @@ def substitute(
 
     with file.open() as f:
         for line in f:
+            line = line.replace("__NIXPKGS__", str(nixpkgs_source()))
             if clan_core_replacement:
-                line = line.replace("__NIXPKGS__", str(nixpkgs_source()))
                 line = line.replace("__CLAN_CORE__", clan_core_replacement)
                 line = line.replace(
                     "git+https://git.clan.lol/clan/clan-core", clan_core_replacement
@@ -385,6 +385,7 @@ def test_flake(
         flake_template="test_flake",
         monkeypatch=monkeypatch,
     )
+
     # check that git diff on ./sops is empty
     if (temporary_home / "test_flake" / "sops").exists():
         git_proc = sp.run(
diff --git a/pkgs/clan-cli/clan_lib/clan/check_test.py b/pkgs/clan-cli/clan_lib/clan/check_test.py
new file mode 100644
index 000000000..1e664352e
--- /dev/null
+++ b/pkgs/clan-cli/clan_lib/clan/check_test.py
@@ -0,0 +1,22 @@
+from pathlib import Path
+
+from clan_cli.tests.fixtures_flakes import FlakeForTest
+
+from clan_lib.clan.check import check_clan_valid
+from clan_lib.flake import Flake
+
+
+def test_check_clan_valid(
+    temporary_home: Path, test_flake_with_core: FlakeForTest, test_flake: FlakeForTest
+) -> None:
+    # Test with a valid clan
+    flake = Flake(str(test_flake_with_core.path))
+    assert check_clan_valid(flake) is True
+
+    # Test with an invalid clan
+    flake = Flake(str(test_flake.path))
+    assert check_clan_valid(flake) is False
+
+    # Test with a non-existent clan
+    flake = Flake(str(temporary_home))
+    assert check_clan_valid(flake) is False