From d46ffe9f4ae832d610ac3bc0c1836e416bda4498 Mon Sep 17 00:00:00 2001
From: Johannes Kirschbauer <hsjobeki@gmail.com>
Date: Tue, 31 Dec 2024 14:54:40 +0100
Subject: [PATCH] Chore:_migrate 'machineName' to 'settings.machine.name'

---
 checks/borgbackup/default.nix                 |  2 +-
 checks/deltachat/default.nix                  |  2 +-
 checks/matrix-synapse/default.nix             |  2 +-
 checks/mumble/default.nix                     |  4 +-
 checks/secrets/default.nix                    |  2 +-
 checks/syncthing/default.nix                  |  6 +--
 checks/wayland-proxy-virtwl/default.nix       |  2 +-
 checks/zt-tcp-relay/default.nix               |  2 +-
 clanModules/borgbackup-static/default.nix     | 10 ++---
 clanModules/borgbackup/roles/client.nix       |  2 +-
 clanModules/borgbackup/roles/server.nix       |  2 +-
 clanModules/deltachat/default.nix             |  2 +-
 clanModules/mumble/default.nix                |  6 +--
 clanModules/mumble/test.nix                   |  4 +-
 clanModules/root-password/default.nix         |  2 +-
 clanModules/sshd/roles/server.nix             |  6 +--
 clanModules/static-hosts/default.nix          |  5 ++-
 .../syncthing-static-peers/default.nix        |  2 +-
 clanModules/user-password/default.nix         |  2 +-
 clanModules/zerotier-static-peers/default.nix |  2 +-
 clanModules/zerotier/shared.nix               |  4 +-
 lib/build-clan/module.nix                     |  7 +++-
 nixosModules/clanCore/facts/compat.nix        |  4 +-
 nixosModules/clanCore/facts/default.nix       |  4 +-
 nixosModules/clanCore/facts/secret/sops.nix   |  8 ++--
 nixosModules/clanCore/metadata.nix            | 42 ++++++++++++-------
 nixosModules/clanCore/nixos-facter.nix        |  2 +-
 nixosModules/clanCore/vars/public/in_repo.nix |  2 +-
 .../clanCore/vars/secret/sops/default.nix     |  2 +-
 nixosModules/clanCore/vm.nix                  |  2 +-
 30 files changed, 84 insertions(+), 60 deletions(-)

diff --git a/checks/borgbackup/default.nix b/checks/borgbackup/default.nix
index aaac67945..c3b3fb9f9 100644
--- a/checks/borgbackup/default.nix
+++ b/checks/borgbackup/default.nix
@@ -16,7 +16,7 @@
             };
           }
           {
-            clan.core.machineName = "machine";
+            clan.core.settings.machine.name = "machine";
             clan.core.settings.directory = ./.;
             clan.core.state.testState.folders = [ "/etc/state" ];
             environment.etc.state.text = "hello world";
diff --git a/checks/deltachat/default.nix b/checks/deltachat/default.nix
index 3f9b3f2d3..857132414 100644
--- a/checks/deltachat/default.nix
+++ b/checks/deltachat/default.nix
@@ -10,7 +10,7 @@
           self.clanModules.deltachat
           self.nixosModules.clanCore
           {
-            clan.core.machineName = "machine";
+            clan.core.settings.machine.name = "machine";
             clan.core.settings.directory = ./.;
           }
         ];
diff --git a/checks/matrix-synapse/default.nix b/checks/matrix-synapse/default.nix
index db5bc5183..5a28efe3b 100644
--- a/checks/matrix-synapse/default.nix
+++ b/checks/matrix-synapse/default.nix
@@ -15,7 +15,7 @@
           self.clanModules.matrix-synapse
           self.nixosModules.clanCore
           {
-            clan.core.machineName = "machine";
+            clan.core.settings.machine.name = "machine";
             clan.core.settings.directory = ./.;
 
             services.nginx.virtualHosts."matrix.clan.test" = {
diff --git a/checks/mumble/default.nix b/checks/mumble/default.nix
index d460e7ed4..7b3382127 100644
--- a/checks/mumble/default.nix
+++ b/checks/mumble/default.nix
@@ -32,7 +32,7 @@
         imports = [
           common
           {
-            clan.core.machineName = "peer1";
+            clan.core.settings.machine.name = "peer1";
             environment.etc = {
               "mumble-key".source = ./peer_1/peer_1_test_key;
               "mumble-cert".source = ./peer_1/peer_1_test_cert;
@@ -64,7 +64,7 @@
         imports = [
           common
           {
-            clan.core.machineName = "peer2";
+            clan.core.settings.machine.name = "peer2";
             environment.etc = {
               "mumble-key".source = ./peer_2/peer_2_test_key;
               "mumble-cert".source = ./peer_2/peer_2_test_cert;
diff --git a/checks/secrets/default.nix b/checks/secrets/default.nix
index 22a70a3ad..e3d542d0d 100644
--- a/checks/secrets/default.nix
+++ b/checks/secrets/default.nix
@@ -11,7 +11,7 @@
       sops.age.keyFile = "/etc/privkey.age";
 
       clan.core.settings.directory = "${./.}";
-      clan.core.machineName = "machine";
+      clan.core.settings.machine.name = "machine";
 
       networking.hostName = "machine";
     };
diff --git a/checks/syncthing/default.nix b/checks/syncthing/default.nix
index 45aac4338..063498e70 100644
--- a/checks/syncthing/default.nix
+++ b/checks/syncthing/default.nix
@@ -12,7 +12,7 @@
           self.clanModules.syncthing
           self.nixosModules.clanCore
           {
-            clan.core.machineName = "introducer";
+            clan.core.settings.machine.name = "introducer";
             clan.core.settings.directory = ./.;
             environment.etc = {
               "syncthing.pam".source = ./introducer/introducer_test_cert;
@@ -53,7 +53,7 @@
           self.clanModules.syncthing
           self.nixosModules.clanCore
           {
-            clan.core.machineName = "peer1";
+            clan.core.settings.machine.name = "peer1";
             clan.core.settings.directory = ./.;
             clan.syncthing.introducer = lib.strings.removeSuffix "\n" (
               builtins.readFile ./introducer/introducer_device_id
@@ -75,7 +75,7 @@
           self.clanModules.syncthing
           self.nixosModules.clanCore
           {
-            clan.core.machineName = "peer2";
+            clan.core.settings.machine.name = "peer2";
             clan.core.settings.directory = ./.;
             clan.syncthing.introducer = lib.strings.removeSuffix "\n" (
               builtins.readFile ./introducer/introducer_device_id
diff --git a/checks/wayland-proxy-virtwl/default.nix b/checks/wayland-proxy-virtwl/default.nix
index 430640333..33f57a162 100644
--- a/checks/wayland-proxy-virtwl/default.nix
+++ b/checks/wayland-proxy-virtwl/default.nix
@@ -14,7 +14,7 @@ import ../lib/test-base.nix (
         imports = [
           self.nixosModules.clanCore
           {
-            clan.core.machineName = "machine";
+            clan.core.settings.machine.name = "machine";
             clan.core.settings.directory = ./.;
           }
         ];
diff --git a/checks/zt-tcp-relay/default.nix b/checks/zt-tcp-relay/default.nix
index c8bd62212..93edab62a 100644
--- a/checks/zt-tcp-relay/default.nix
+++ b/checks/zt-tcp-relay/default.nix
@@ -10,7 +10,7 @@
           self.nixosModules.clanCore
           self.clanModules.zt-tcp-relay
           {
-            clan.core.machineName = "machine";
+            clan.core.settings.machine.name = "machine";
             clan.core.settings.directory = ./.;
           }
         ];
diff --git a/clanModules/borgbackup-static/default.nix b/clanModules/borgbackup-static/default.nix
index 45e07eb62..a6c529b92 100644
--- a/clanModules/borgbackup-static/default.nix
+++ b/clanModules/borgbackup-static/default.nix
@@ -9,7 +9,7 @@ in
   options.clan.borgbackup-static = {
     excludeMachines = lib.mkOption {
       type = lib.types.listOf lib.types.str;
-      example = [ config.clan.core.machineName ];
+      example = [ config.clan.core.settings.machine.name ];
       default = [ ];
       description = ''
         Machines that should not be backuped.
@@ -20,7 +20,7 @@ in
     };
     includeMachines = lib.mkOption {
       type = lib.types.listOf lib.types.str;
-      example = [ config.clan.core.machineName ];
+      example = [ config.clan.core.settings.machine.name ];
       default = [ ];
       description = ''
         Machines that should be backuped.
@@ -63,7 +63,7 @@ in
     in
     lib.mkIf
       (builtins.any (
-        target: target == config.clan.core.machineName
+        target: target == config.clan.core.settings.machine.name
       ) config.clan.borgbackup-static.targets)
       (if (builtins.listToAttrs hosts) != null then builtins.listToAttrs hosts else { });
 
@@ -72,12 +72,12 @@ in
       destinations = builtins.map (d: {
         name = d;
         value = {
-          repo = "borg@${d}:/var/lib/borgbackup/${config.clan.core.machineName}";
+          repo = "borg@${d}:/var/lib/borgbackup/${config.clan.core.settings.machine.name}";
         };
       }) config.clan.borgbackup-static.targets;
     in
     lib.mkIf (builtins.any (
-      target: target == config.clan.core.machineName
+      target: target == config.clan.core.settings.machine.name
     ) config.clan.borgbackup-static.includeMachines) (builtins.listToAttrs destinations);
 
   config.assertions = [
diff --git a/clanModules/borgbackup/roles/client.nix b/clanModules/borgbackup/roles/client.nix
index bb4439d84..1a8e14d6a 100644
--- a/clanModules/borgbackup/roles/client.nix
+++ b/clanModules/borgbackup/roles/client.nix
@@ -19,7 +19,7 @@ let
     )
   ) [ ] instances;
 
-  inherit (config.clan.core) machineName;
+  machineName = config.clan.core.settings.machine.name;
 
   cfg = config.clan.borgbackup;
   preBackupScript = ''
diff --git a/clanModules/borgbackup/roles/server.nix b/clanModules/borgbackup/roles/server.nix
index 4c6442efb..cb510ad29 100644
--- a/clanModules/borgbackup/roles/server.nix
+++ b/clanModules/borgbackup/roles/server.nix
@@ -2,7 +2,7 @@
 let
   dir = config.clan.core.settings.directory;
   machineDir = dir + "/machines/";
-  inherit (config.clan.core) machineName;
+  machineName = config.clan.core.settings.machine.name;
 
   # Instances might be empty, if the module is not used via the inventory
   #
diff --git a/clanModules/deltachat/default.nix b/clanModules/deltachat/default.nix
index 33cc6554b..5b68f083b 100644
--- a/clanModules/deltachat/default.nix
+++ b/clanModules/deltachat/default.nix
@@ -5,7 +5,7 @@
 
   services.maddy =
     let
-      domain = "${config.clan.core.machineName}.local";
+      domain = "${config.clan.core.settings.machine.name}.local";
     in
     {
       enable = true;
diff --git a/clanModules/mumble/default.nix b/clanModules/mumble/default.nix
index f8f77b598..ba3302219 100644
--- a/clanModules/mumble/default.nix
+++ b/clanModules/mumble/default.nix
@@ -39,7 +39,7 @@ in
     services.murmur = {
       enable = true;
       logDays = -1;
-      registerName = config.clan.core.machineName;
+      registerName = config.clan.core.settings.machine.name;
       openFirewall = true;
       bonjour = true;
       sslKey = "/var/lib/murmur/sslKey";
@@ -97,8 +97,8 @@ in
           XDG_DATA_DIR=${mumbleCfgDir}
           ${populate-channels} --ensure-config '${mumbleCfgPath}' --db-location ${mumbleDatabasePath}
           echo ${machineCertJson}
-          ${populate-channels} --machines '${machineJson}' --username ${config.clan.core.machineName} --db-location ${mumbleDatabasePath}
-          ${populate-channels} --servers '${machineCertJson}' --username ${config.clan.core.machineName} --db-location ${mumbleDatabasePath} --cert True
+          ${populate-channels} --machines '${machineJson}' --username ${config.clan.core.settings.machine.name} --db-location ${mumbleDatabasePath}
+          ${populate-channels} --servers '${machineCertJson}' --username ${config.clan.core.settings.machine.name} --db-location ${mumbleDatabasePath} --cert True
           ${pkgs.mumble}/bin/mumble --config ${mumbleCfgPath} "$@"
           popd
         '';
diff --git a/clanModules/mumble/test.nix b/clanModules/mumble/test.nix
index 7edc1421c..ec18db977 100644
--- a/clanModules/mumble/test.nix
+++ b/clanModules/mumble/test.nix
@@ -9,7 +9,7 @@ pkgs.nixosTest {
         self.inputs.clan-core.nixosModules.clanCore
         {
           config = {
-            clan.core.machineName = "peer1";
+            clan.core.settings.machine.name = "peer1";
             clan.core.settings.directory = ./.;
 
             documentation.enable = false;
@@ -26,7 +26,7 @@ pkgs.nixosTest {
         {
           config = {
 
-            clan.core.machineName = "peer2";
+            clan.core.settings.machine.name = "peer2";
             clan.core.settings.directory = ./.;
 
             documentation.enable = false;
diff --git a/clanModules/root-password/default.nix b/clanModules/root-password/default.nix
index a340730e3..932e76d69 100644
--- a/clanModules/root-password/default.nix
+++ b/clanModules/root-password/default.nix
@@ -10,7 +10,7 @@
     config.clan.core.facts.services.root-password.secret.password-hash.path;
 
   sops.secrets = lib.mkIf (config.clan.core.facts.secretStore == "sops") {
-    "${config.clan.core.machineName}-password-hash".neededForUsers = true;
+    "${config.clan.core.settings.machine.name}-password-hash".neededForUsers = true;
   };
 
   clan.core.facts.services.root-password = {
diff --git a/clanModules/sshd/roles/server.nix b/clanModules/sshd/roles/server.nix
index e7d409722..bf02fe306 100644
--- a/clanModules/sshd/roles/server.nix
+++ b/clanModules/sshd/roles/server.nix
@@ -69,7 +69,7 @@ in
         "openssh-ca"
       ];
       validation = {
-        name = config.clan.core.machineName;
+        name = config.clan.core.settings.machine.name;
         domains = lib.genAttrs config.clan.sshd.certificate.searchDomains lib.id;
       };
       runtimeInputs = [
@@ -79,9 +79,9 @@ in
       script = ''
         ssh-keygen \
           -s $in/openssh-ca/id_ed25519 \
-          -I ${config.clan.core.machineName} \
+          -I ${config.clan.core.settings.machine.name} \
           -h \
-          -n ${lib.concatMapStringsSep "," (d: "${config.clan.core.machineName}.${d}") domains} \
+          -n ${lib.concatMapStringsSep "," (d: "${config.clan.core.settings.machine.name}.${d}") domains} \
           $in/openssh/ssh.id_ed25519.pub
         mv $in/openssh/ssh.id_ed25519-cert.pub $out/ssh.id_ed25519-cert.pub
       '';
diff --git a/clanModules/static-hosts/default.nix b/clanModules/static-hosts/default.nix
index 3208f4c6d..2e2f25ccc 100644
--- a/clanModules/static-hosts/default.nix
+++ b/clanModules/static-hosts/default.nix
@@ -4,7 +4,10 @@
     excludeHosts = lib.mkOption {
       type = lib.types.listOf lib.types.str;
       default =
-        if config.clan.static-hosts.topLevelDomain != "" then [ ] else [ config.clan.core.machineName ];
+        if config.clan.static-hosts.topLevelDomain != "" then
+          [ ]
+        else
+          [ config.clan.core.settings.machine.name ];
       description = "Hosts that should be excluded";
     };
     topLevelDomain = lib.mkOption {
diff --git a/clanModules/syncthing-static-peers/default.nix b/clanModules/syncthing-static-peers/default.nix
index 111e93af8..dd0b3ea6a 100644
--- a/clanModules/syncthing-static-peers/default.nix
+++ b/clanModules/syncthing-static-peers/default.nix
@@ -47,7 +47,7 @@ in
   options.clan.syncthing-static-peers = {
     excludeMachines = lib.mkOption {
       type = lib.types.listOf lib.types.str;
-      example = [ config.clan.core.machineName ];
+      example = [ config.clan.core.settings.machine.name ];
       default = [ ];
       description = ''
         Machines that should not be added.
diff --git a/clanModules/user-password/default.nix b/clanModules/user-password/default.nix
index f74317d75..296dbb733 100644
--- a/clanModules/user-password/default.nix
+++ b/clanModules/user-password/default.nix
@@ -30,7 +30,7 @@ in
     };
 
     sops.secrets = lib.mkIf (config.clan.core.facts.secretStore == "sops") {
-      "${config.clan.core.machineName}-user-password-hash".neededForUsers = true;
+      "${config.clan.core.settings.machine.name}-user-password-hash".neededForUsers = true;
     };
 
     clan.core.facts.services.user-password = {
diff --git a/clanModules/zerotier-static-peers/default.nix b/clanModules/zerotier-static-peers/default.nix
index a9377bed6..96abe878f 100644
--- a/clanModules/zerotier-static-peers/default.nix
+++ b/clanModules/zerotier-static-peers/default.nix
@@ -27,7 +27,7 @@ in
   options.clan.zerotier-static-peers = {
     excludeHosts = lib.mkOption {
       type = lib.types.listOf lib.types.str;
-      default = [ config.clan.core.machineName ];
+      default = [ config.clan.core.settings.machine.name ];
       description = "Hosts that should be excluded";
     };
     networkIps = lib.mkOption {
diff --git a/clanModules/zerotier/shared.nix b/clanModules/zerotier/shared.nix
index aa3748cba..b1eb9f709 100644
--- a/clanModules/zerotier/shared.nix
+++ b/clanModules/zerotier/shared.nix
@@ -34,7 +34,7 @@ in
     {
       excludeHosts = lib.mkOption {
         type = listOf str;
-        default = [ config.clan.core.machineName ];
+        default = [ config.clan.core.settings.machine.name ];
         description = "Hosts that should be excluded";
       };
       networkIps = lib.mkOption {
@@ -54,7 +54,7 @@ in
       # TODO: This should also be checked via frontmatter constraints
       {
         assertion = builtins.length instanceNames == 1;
-        message = "The zerotier module currently only supports one instance per machine, but found ${builtins.toString instanceNames} on machine ${config.clan.core.machineName}";
+        message = "The zerotier module currently only supports one instance per machine, but found ${builtins.toString instanceNames} on machine ${config.clan.core.settings.machine.name}";
       }
     ];
 
diff --git a/lib/build-clan/module.nix b/lib/build-clan/module.nix
index 2b28edbe5..681c7f3a1 100644
--- a/lib/build-clan/module.nix
+++ b/lib/build-clan/module.nix
@@ -82,6 +82,10 @@ let
               # Settings
               clan.core.settings = {
                 inherit directory;
+
+                machine = {
+                  inherit name;
+                };
               };
               # clan.core.settings.directory = directory;
               # Inherited from clan wide settings
@@ -90,7 +94,8 @@ let
               clan.core.icon = config.inventory.meta.icon;
 
               # Machine specific settings
-              clan.core.machineName = name;
+              # clan.core.settings.machine.name = name;
+
               networking.hostName = lib.mkDefault name;
 
               # speeds up nix commands by using the nixpkgs from the host system (especially useful in VMs)
diff --git a/nixosModules/clanCore/facts/compat.nix b/nixosModules/clanCore/facts/compat.nix
index 6b840efe4..8fc81b233 100644
--- a/nixosModules/clanCore/facts/compat.nix
+++ b/nixosModules/clanCore/facts/compat.nix
@@ -141,8 +141,8 @@
                     '';
                     default =
                       config.clan.core.settings.directory
-                      + "/machines/${config.clan.core.machineName}/facts/${fact.config._module.args.name}";
-                    defaultText = lib.literalExpression "\${config.clan.core.settings.directory}/machines/\${config.clan.core.machineName}/facts/\${fact.config._module.args.name}";
+                      + "/machines/${config.clan.core.settings.machine.name}/facts/${fact.config._module.args.name}";
+                    defaultText = lib.literalExpression "\${config.clan.core.settings.directory}/machines/\${config.clan.core.settings.machine.name}/facts/\${fact.config._module.args.name}";
                   };
                   value = lib.mkOption {
                     defaultText = lib.literalExpression "\${config.clan.core.settings.directory}/\${fact.config.path}";
diff --git a/nixosModules/clanCore/facts/default.nix b/nixosModules/clanCore/facts/default.nix
index b9f4019ae..7f8c6781b 100644
--- a/nixosModules/clanCore/facts/default.nix
+++ b/nixosModules/clanCore/facts/default.nix
@@ -219,10 +219,10 @@
                       description = ''
                         path to a fact which is generated by the generator
                       '';
-                      defaultText = lib.literalExpression "\${config.clan.core.settings.directory}/machines/\${config.clan.core.machineName}/facts/\${fact.config.name}";
+                      defaultText = lib.literalExpression "\${config.clan.core.settings.directory}/machines/\${config.clan.core.settings.machine.name}/facts/\${fact.config.name}";
                       default =
                         config.clan.core.settings.directory
-                        + "/machines/${config.clan.core.machineName}/facts/${fact.config.name}";
+                        + "/machines/${config.clan.core.settings.machine.name}/facts/${fact.config.name}";
                     };
                     value = lib.mkOption {
                       description = ''
diff --git a/nixosModules/clanCore/facts/secret/sops.nix b/nixosModules/clanCore/facts/secret/sops.nix
index b2e2b92b2..989a4a6e5 100644
--- a/nixosModules/clanCore/facts/secret/sops.nix
+++ b/nixosModules/clanCore/facts/secret/sops.nix
@@ -16,7 +16,8 @@ let
 
   containsMachine =
     parent: name: type:
-    type == "directory" && containsSymlink "${parent}/${name}/machines/${config.clan.core.machineName}";
+    type == "directory"
+    && containsSymlink "${parent}/${name}/machines/${config.clan.core.settings.machine.name}";
 
   containsMachineOrGroups =
     name: type:
@@ -37,7 +38,7 @@ in
     # Before we generate a secret we cannot know the path yet, so we need to set it to an empty string
     clan.core.facts.secretPathFunction =
       secret:
-      config.sops.secrets.${"${config.clan.core.machineName}-${secret.config.name}"}.path
+      config.sops.secrets.${"${config.clan.core.settings.machine.name}-${secret.config.name}"}.path
         or "/no-such-path";
     clan.core.facts.secretModule = "clan_cli.facts.secret_modules.sops";
     clan.core.facts.secretUploadDirectory = lib.mkDefault "/var/lib/sops-nix";
@@ -51,7 +52,8 @@ in
     );
 
     sops.age.keyFile = lib.mkIf (builtins.pathExists (
-      config.clan.core.settings.directory + "/sops/secrets/${config.clan.core.machineName}-age.key/secret"
+      config.clan.core.settings.directory
+      + "/sops/secrets/${config.clan.core.settings.machine.name}-age.key/secret"
     )) (lib.mkDefault "/var/lib/sops-nix/key.txt");
   };
 }
diff --git a/nixosModules/clanCore/metadata.nix b/nixosModules/clanCore/metadata.nix
index 2dc605436..08eb8c6d0 100644
--- a/nixosModules/clanCore/metadata.nix
+++ b/nixosModules/clanCore/metadata.nix
@@ -15,6 +15,7 @@ in
       "clanIcon"
     ] "clanIcon has been removed. Use clan.core.icon instead.")
 
+    # The following options have been moved into clan.core.settings
     (lib.mkRenamedOptionModule
       [ "clan" "core" "clanDir" ]
       [
@@ -24,6 +25,17 @@ in
         "directory"
       ]
     )
+    # The following options have been moved into clan.core.settings.machine
+    (lib.mkRenamedOptionModule
+      [ "clan" "core" "machineName" ]
+      [
+        "clan"
+        "core"
+        "settings"
+        "machine"
+        "name"
+      ]
+    )
   ];
   options.clan.core = {
     settings = mkOption {
@@ -34,17 +46,26 @@ in
       '';
       type = types.submodule {
         options = {
-          directory = lib.mkOption {
-            type = lib.types.path;
-            # documentation.nixos.extraModules = [
-            #   ...
-            #   clan-core.nixosModules.clanCore
-            #   { clan.core.settings.directory = ./path/to/flake; }
-            # ];
+          directory = mkOption {
+            type = types.path;
             description = ''
               the location of the flake repo, used to calculate the location of facts and secrets
             '';
           };
+          machine = mkOption {
+            default = {};
+            type = types.submodule {
+              options = {
+                name = mkOption {
+                  type = types.str;
+                  default = "nixos";
+                  description = ''
+                    the name of the machine
+                  '';
+                };
+              };
+            };
+          };
         };
       };
     };
@@ -79,13 +100,6 @@ in
         the description of the machine
       '';
     };
-    machineName = lib.mkOption {
-      type = lib.types.str;
-      default = "nixos";
-      description = ''
-        the name of the machine
-      '';
-    };
     clanPkgs = lib.mkOption {
       defaultText = "self.packages.${pkgs.system}";
       internal = true;
diff --git a/nixosModules/clanCore/nixos-facter.nix b/nixosModules/clanCore/nixos-facter.nix
index 890238040..355d1be39 100644
--- a/nixosModules/clanCore/nixos-facter.nix
+++ b/nixosModules/clanCore/nixos-facter.nix
@@ -1,7 +1,7 @@
 { lib, config, ... }:
 let
   directory = config.clan.core.settings.directory;
-  inherit (config.clan.core) machineName;
+  machineName = config.clan.core.settings.machine.name;
   facterJson = "${directory}/machines/${machineName}/facter.json";
   hwConfig = "${directory}/machines/${machineName}/hardware-configuration.nix";
 in
diff --git a/nixosModules/clanCore/vars/public/in_repo.nix b/nixosModules/clanCore/vars/public/in_repo.nix
index 399c03be1..088cc6b67 100644
--- a/nixosModules/clanCore/vars/public/in_repo.nix
+++ b/nixosModules/clanCore/vars/public/in_repo.nix
@@ -20,7 +20,7 @@ in
         else
           (
             config.clan.core.settings.directory
-            + "/vars/per-machine/${config.clan.core.machineName}/${file.config.generatorName}/${file.config.name}/value"
+            + "/vars/per-machine/${config.clan.core.settings.machine.name}/${file.config.generatorName}/${file.config.name}/value"
           )
       );
       value = mkIf (file.config.secret == false) (
diff --git a/nixosModules/clanCore/vars/secret/sops/default.nix b/nixosModules/clanCore/vars/secret/sops/default.nix
index 1b4893164..b05c91be1 100644
--- a/nixosModules/clanCore/vars/secret/sops/default.nix
+++ b/nixosModules/clanCore/vars/secret/sops/default.nix
@@ -10,7 +10,7 @@ let
 
   inherit (import ./funcs.nix { inherit lib; }) collectFiles;
 
-  inherit (config.clan.core) machineName;
+  machineName = config.clan.core.settings.machine.name;
 
   secretPath =
     secret:
diff --git a/nixosModules/clanCore/vm.nix b/nixosModules/clanCore/vm.nix
index 05951f6be..ed03ee6eb 100644
--- a/nixosModules/clanCore/vm.nix
+++ b/nixosModules/clanCore/vm.nix
@@ -252,7 +252,7 @@ in
     clan.core.vm.inspect = {
       clan_name = config.clan.core.name;
       machine_icon = config.clan.core.machineIcon or config.clan.core.icon;
-      machine_name = config.clan.core.machineName;
+      machine_name = config.clan.core.settings.machine.name;
       machine_description = config.clan.core.machineDescription;
       memory_size = config.clan.virtualisation.memorySize;
       inherit (config.clan.virtualisation) cores graphics waypipe;