yadunut/clan-core
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

logger: only get file path if actually requested

Browse Source 
this is a rather expensive operation.
This commit is contained in:
Jörg Thalheim
2025-05-20 10:05:06 +02:00
parent 5d99fb1e47
commit bbb6a1546b
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
pkgs/clan-cli/clan_cli/custom_logger.py
View File

@@ -32,8 +32,6 @@ class PrefixFormatter(logging.Formatter):
self.hostname_color_offset = 0 self.hostname_color_offset = 0
def format(self, record: logging.LogRecord) -> str: def format(self, record: logging.LogRecord) -> str:
filepath = _get_filepath(record)
# If extra["color"] is set, use that color for the message. # If extra["color"] is set, use that color for the message.
msg_color = getattr(record, "color", None) msg_color = getattr(record, "color", None)
if not msg_color: if not msg_color:
@@ -71,6 +69,7 @@ class PrefixFormatter(logging.Formatter):
# Add the source file and line number if trace_prints is enabled. # Add the source file and line number if trace_prints is enabled.
if self.trace_prints: if self.trace_prints:
filepath = _get_filepath(record)
format_str += f"\nSource: {filepath}:%(lineno)d::%(funcName)s\n" format_str += f"\nSource: {filepath}:%(lineno)d::%(funcName)s\n"
return logging.Formatter(format_str).format(record) return logging.Formatter(format_str).format(record)