Updated to main

pkgs/clan-cli/clan_cli/machines/__init__.py

@@ -23,8 +23,8 @@ def register_parser(parser: argparse.ArgumentParser) -> None:
     create_parser = subparser.add_parser("create", help="Create a machine")
     register_create_parser(create_parser)
 
-    remove_parser = subparser.add_parser("remove", help="Remove a machine")
-    register_delete_parser(remove_parser)
+    delete_parser = subparser.add_parser("delete", help="Delete a machine")
+    register_delete_parser(delete_parser)
 
     list_parser = subparser.add_parser("list", help="List machines")
     register_list_parser(list_parser)

pkgs/clan-cli/clan_cli/machines/create.py

@@ -3,31 +3,49 @@ import logging
 from typing import Dict
 
 from ..async_cmd import CmdOut, run, runforcli
+from ..dirs import get_flake_path, specific_machine_dir
+from ..errors import ClanError
 from ..nix import nix_shell
-from .folders import machine_folder
 
 log = logging.getLogger(__name__)
 
-async def create_machine(name: str) -> Dict[str, CmdOut]:
-    folder = machine_folder(name)
+
+async def create_machine(flake_name: str, machine_name: str) -> Dict[str, CmdOut]:
+    folder = specific_machine_dir(flake_name, machine_name)
     folder.mkdir(parents=True, exist_ok=True)
 
     # create empty settings.json file inside the folder
     with open(folder / "settings.json", "w") as f:
         f.write("{}")
     response = {}
-    out = await run(nix_shell(["git"], ["git", "add", str(folder)]))
+    out = await run(nix_shell(["git"], ["git", "add", str(folder)]), cwd=folder)
     response["git add"] = out
 
-    out = await run(nix_shell(["git"], ["git", "commit", "-m", f"Added machine {name}", str(folder)]))
+    out = await run(
+        nix_shell(
+            ["git"],
+            ["git", "commit", "-m", f"Added machine {machine_name}", str(folder)],
+        ),
+        cwd=folder,
+    )
     response["git commit"] = out
 
     return response
 
+
 def create_command(args: argparse.Namespace) -> None:
-    runforcli(create_machine, args.host)
+    try:
+        flake_dir = get_flake_path(args.flake)
+        runforcli(create_machine, flake_dir, args.machine)
+    except ClanError as e:
+        print(e)
 
 
 def register_create_parser(parser: argparse.ArgumentParser) -> None:
-    parser.add_argument("host", type=str)
+    parser.add_argument("machine", type=str)
+    parser.add_argument(
+        "flake",
+        type=str,
+        help="name of the flake to create machine for",
+    )
     parser.set_defaults(func=create_command)

pkgs/clan-cli/clan_cli/machines/delete.py

@@ -1,12 +1,12 @@
 import argparse
 import shutil
 
+from ..dirs import specific_machine_dir
 from ..errors import ClanError
-from .folders import machine_folder
 
 
 def delete_command(args: argparse.Namespace) -> None:
-    folder = machine_folder(args.host)
+    folder = specific_machine_dir(args.flake, args.host)
     if folder.exists():
         shutil.rmtree(folder)
     else:
@@ -15,4 +15,9 @@ def delete_command(args: argparse.Namespace) -> None:
 
 def register_delete_parser(parser: argparse.ArgumentParser) -> None:
     parser.add_argument("host", type=str)
+    parser.add_argument(
+        "flake",
+        type=str,
+        help="name of the flake to create machine for",
+    )
     parser.set_defaults(func=delete_command)

pkgs/clan-cli/clan_cli/machines/facts.py

@@ -1,9 +1,9 @@
-from .folders import machine_folder
+from ..dirs import specific_machine_dir
 
 
-def machine_has_fact(machine: str, fact: str) -> bool:
-    return (machine_folder(machine) / "facts" / fact).exists()
+def machine_has_fact(flake_name: str, machine: str, fact: str) -> bool:
+    return (specific_machine_dir(flake_name, machine) / "facts" / fact).exists()
 
 
-def machine_get_fact(machine: str, fact: str) -> str:
-    return (machine_folder(machine) / "facts" / fact).read_text()
+def machine_get_fact(flake_name: str, machine: str, fact: str) -> str:
+    return (specific_machine_dir(flake_name, machine) / "facts" / fact).read_text()

pkgs/clan-cli/clan_cli/machines/folders.py

@@ -1,15 +0,0 @@
-from pathlib import Path
-
-from ..dirs import get_clan_flake_toplevel
-
-
-def machines_folder() -> Path:
-    return get_clan_flake_toplevel() / "machines"
-
-
-def machine_folder(machine: str) -> Path:
-    return machines_folder() / machine
-
-
-def machine_settings_file(machine: str) -> Path:
-    return machine_folder(machine) / "settings.json"

pkgs/clan-cli/clan_cli/machines/install.py

@@ -3,6 +3,7 @@ import subprocess
 from pathlib import Path
 from tempfile import TemporaryDirectory
 
+from ..dirs import get_flake_path
 from ..machines.machines import Machine
 from ..nix import nix_shell
 from ..secrets.generate import generate_secrets
@@ -26,7 +27,7 @@ def install_nixos(machine: Machine) -> None:
                 [
                     "nixos-anywhere",
                     "-f",
-                    f"{machine.clan_dir}#{flake_attr}",
+                    f"{machine.flake_dir}#{flake_attr}",
                     "-t",
                     "--no-reboot",
                     "--extra-files",
@@ -39,7 +40,7 @@ def install_nixos(machine: Machine) -> None:
 
 
 def install_command(args: argparse.Namespace) -> None:
-    machine = Machine(args.machine)
+    machine = Machine(args.machine, flake_dir=get_flake_path(args.flake))
     machine.deployment_address = args.target_host
 
     install_nixos(machine)
@@ -56,5 +57,9 @@ def register_install_parser(parser: argparse.ArgumentParser) -> None:
         type=str,
         help="ssh address to install to in the form of user@host:2222",
     )
-
+    parser.add_argument(
+        "flake",
+        type=str,
+        help="name of the flake to install machine from",
+    )
     parser.set_defaults(func=install_command)

pkgs/clan-cli/clan_cli/machines/list.py

@@ -2,14 +2,14 @@ import argparse
 import logging
 import os
 
-from .folders import machines_folder
+from ..dirs import machines_dir
 from .types import validate_hostname
 
 log = logging.getLogger(__name__)
 
 
-def list_machines() -> list[str]:
-    path = machines_folder()
+def list_machines(flake_name: str) -> list[str]:
+    path = machines_dir(flake_name)
     log.debug(f"Listing machines in {path}")
     if not path.exists():
         return []
@@ -21,9 +21,14 @@ def list_machines() -> list[str]:
 
 
 def list_command(args: argparse.Namespace) -> None:
-    for machine in list_machines():
+    for machine in list_machines(args.flake):
         print(machine)
 
 
 def register_list_parser(parser: argparse.ArgumentParser) -> None:
+    parser.add_argument(
+        "flake",
+        type=str,
+        help="name of the flake to create machine for",
+    )
     parser.set_defaults(func=list_command)

pkgs/clan-cli/clan_cli/machines/machines.py

@@ -31,7 +31,7 @@ class Machine:
     def __init__(
         self,
         name: str,
-        clan_dir: Optional[Path] = None,
+        flake_dir: Optional[Path] = None,
         machine_data: Optional[dict] = None,
     ) -> None:
         """
@@ -41,13 +41,13 @@ class Machine:
         @machine_json: can be optionally used to skip evaluation of the machine, location of the json file with machine data
         """
         self.name = name
-        if clan_dir is None:
-            self.clan_dir = get_clan_flake_toplevel()
+        if flake_dir is None:
+            self.flake_dir = get_clan_flake_toplevel()
         else:
-            self.clan_dir = clan_dir
+            self.flake_dir = flake_dir
 
         if machine_data is None:
-            self.machine_data = build_machine_data(name, self.clan_dir)
+            self.machine_data = build_machine_data(name, self.flake_dir)
         else:
             self.machine_data = machine_data
 
@@ -68,7 +68,7 @@ class Machine:
         @secrets_dir: the directory to store the secrets in
         """
         env = os.environ.copy()
-        env["CLAN_DIR"] = str(self.clan_dir)
+        env["CLAN_DIR"] = str(self.flake_dir)
         env["PYTHONPATH"] = str(
             ":".join(sys.path)
         )  # TODO do this in the clanCore module
@@ -95,7 +95,7 @@ class Machine:
         @attr: the attribute to get
         """
         output = subprocess.run(
-            nix_eval([f"path:{self.clan_dir}#{attr}"]),
+            nix_eval([f"path:{self.flake_dir}#{attr}"]),
             stdout=subprocess.PIPE,
             check=True,
             text=True,
@@ -108,7 +108,7 @@ class Machine:
         @attr: the attribute to get
         """
         outpath = subprocess.run(
-            nix_build([f"path:{self.clan_dir}#{attr}"]),
+            nix_build([f"path:{self.flake_dir}#{attr}"]),
             stdout=subprocess.PIPE,
             check=True,
             text=True,

pkgs/clan-cli/clan_cli/machines/update.py

@@ -4,7 +4,7 @@ import os
 import subprocess
 from pathlib import Path
 
-from ..dirs import get_clan_flake_toplevel
+from ..dirs import get_flake_path
 from ..machines.machines import Machine
 from ..nix import nix_build, nix_command, nix_config
 from ..secrets.generate import generate_secrets
@@ -101,19 +101,19 @@ def get_all_machines(clan_dir: Path) -> HostGroup:
     return HostGroup(hosts)
 
 
-def get_selected_machines(machine_names: list[str], clan_dir: Path) -> HostGroup:
+def get_selected_machines(machine_names: list[str], flake_dir: Path) -> HostGroup:
     hosts = []
     for name in machine_names:
-        machine = Machine(name=name, clan_dir=clan_dir)
+        machine = Machine(name=name, flake_dir=flake_dir)
         hosts.append(machine.host)
     return HostGroup(hosts)
 
 
 # FIXME: we want some kind of inventory here.
 def update(args: argparse.Namespace) -> None:
-    clan_dir = get_clan_flake_toplevel()
+    flake_dir = get_flake_path(args.flake)
     if len(args.machines) == 1 and args.target_host is not None:
-        machine = Machine(name=args.machines[0], clan_dir=clan_dir)
+        machine = Machine(name=args.machines[0], flake_dir=flake_dir)
         machine.deployment_address = args.target_host
         host = parse_deployment_address(
             args.machines[0],
@@ -127,11 +127,11 @@ def update(args: argparse.Namespace) -> None:
         exit(1)
     else:
         if len(args.machines) == 0:
-            machines = get_all_machines(clan_dir)
+            machines = get_all_machines(flake_dir)
         else:
-            machines = get_selected_machines(args.machines, clan_dir)
+            machines = get_selected_machines(args.machines, flake_dir)
 
-    deploy_nixos(machines, clan_dir)
+    deploy_nixos(machines, flake_dir)
 
 
 def register_update_parser(parser: argparse.ArgumentParser) -> None:
@@ -142,6 +142,11 @@ def register_update_parser(parser: argparse.ArgumentParser) -> None:
         nargs="*",
         default=[],
     )
+    parser.add_argument(
+        "flake",
+        type=str,
+        help="name of the flake to update machine for",
+    )
     parser.add_argument(
         "--target-host",
         type=str,