yadunut/clan-core
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

api: remove unused validation method

Browse Source
This commit is contained in:
Johannes Kirschbauer
2025-10-15 16:19:21 +02:00
parent 16d245b179
commit a32a5151dc
2 changed files with 0 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pkgs/clan-cli/clan_lib/persist/patch_engine.py
View File

@@ -90,9 +90,6 @@ def calc_patches(
update_flat = flatten_data_structured(update)
all_values_flat = flatten_data_structured(all_values)
# Early validation: ensure we're not trying to modify static-only paths
# validate_no_static_modification(update_flat, static_data)
# Find paths marked for deletion
delete_paths = find_deleted_paths_structured(all_values, update)
@@ -133,7 +130,6 @@ Please report this issue at https://git.clan.lol/clan/clan-core/issues
continue
# Validate the change is allowed
# validate_no_static_deletion(path, new_value, static_data)
validate_writeability(path, attribute_props)
validate_type_compatibility(path, old_value, new_value)
validate_list_uniqueness(path, new_value)

19
pkgs/clan-cli/clan_lib/persist/validate.py
View File

@@ -10,25 +10,6 @@ from clan_lib.persist.path_utils import (
from clan_lib.persist.write_rules import AttributeMap, is_writeable_path
def validate_no_static_deletion(
path: PathTuple, new_value: Any, static_data: dict[PathTuple, Any]
) -> None:
"""Validate that we're not trying to delete static data."""
# Check if we're trying to delete a path that exists in static data
if path in static_data and new_value is None:
msg = f"Path '{path_to_string(path)}' is readonly - since its defined via a .nix file"
raise ClanError(msg)
# For lists, check if we're trying to remove static items
if isinstance(new_value, list) and path in static_data:
static_items = static_data[path]
if isinstance(static_items, list):
missing_static = [item for item in static_items if item not in new_value]
if missing_static:
msg = f"Path '{path_to_string(path)}' doesn't contain static items {missing_static} - They are readonly - since they are defined via a .nix file"
raise ClanError(msg)
def validate_writeability(path: PathTuple, writeables: AttributeMap) -> None:
"""Validate that a path is writeable."""
if not is_writeable_path(path, writeables):