yadunut/clan-core
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

clan-vm-manager: make joining clan url more logical

Browse Source 
The icon is confusing. It distracts from the actual "Join" label. Also when a user
copy in an URL we can assume they trust the content, which might be not the case
when they just clicked on an URL.
This commit is contained in:
Jörg Thalheim
2024-01-04 17:08:01 +01:00
parent 093566aa42
commit 6a75ea56fd
1 changed files with 11 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
pkgs/clan-vm-manager/clan_vm_manager/windows/join.py
View File

@@ -38,15 +38,14 @@ class Trust(Gtk.Box):
) )
layout = Gtk.Box(orientation=Gtk.Orientation.VERTICAL, expand=True) layout = Gtk.Box(orientation=Gtk.Orientation.VERTICAL, expand=True)
layout.set_border_width(20) layout.set_border_width(20)
layout.set_spacing(20)
upper = Gtk.Box(orientation="vertical")
upper.set_spacing(20)
if self.url is not None: if self.url is not None:
self.entry = Gtk.Label(label=str(self.url)) self.entry = Gtk.Label(label=str(self.url))
upper.add(Gtk.Label(label="Clan URL")) layout.add(icon)
layout.add(Gtk.Label(label="Clan URL"))
else: else:
upper.add(Gtk.Label(label="Enter Clan URL")) layout.add(Gtk.Label(label="Enter Clan URL"))
self.entry = Gtk.Entry() self.entry = Gtk.Entry()
# Autocomplete # Autocomplete
# TODO: provide intelligent suggestions # TODO: provide intelligent suggestions
@@ -61,17 +60,16 @@ class Trust(Gtk.Box):
self.entry.set_completion(completion) self.entry.set_completion(completion)
self.entry.set_placeholder_text("clan://") self.entry.set_placeholder_text("clan://")
upper.add(icon) layout.add(self.entry)
upper.add(self.entry)
if self.url is None:
trust_button = Gtk.Button(label="Load cLAN-URL")
else:
trust_button = Gtk.Button(label="Trust cLAN-URL")
lower = Gtk.Box(orientation="vertical")
lower.set_spacing(20)
trust_button = Gtk.Button(label="Trust")
trust_button.connect("clicked", self.on_trust_clicked) trust_button.connect("clicked", self.on_trust_clicked)
lower.add(trust_button) layout.add(trust_button)
layout.pack_start(upper, expand=True, fill=True, padding=0)
layout.pack_end(lower, expand=True, fill=True, padding=0)
self.set_center_widget(layout) self.set_center_widget(layout)
def on_trust_clicked(self, widget: Gtk.Widget) -> None: def on_trust_clicked(self, widget: Gtk.Widget) -> None: