use pathlib everywhere
This commit is contained in:
@@ -64,7 +64,7 @@ def _init_proc(
|
||||
os.setsid()
|
||||
|
||||
# Open stdout and stderr
|
||||
with open(out_file, "w") as out_fd:
|
||||
with out_file.open("w") as out_fd:
|
||||
os.dup2(out_fd.fileno(), sys.stdout.fileno())
|
||||
os.dup2(out_fd.fileno(), sys.stderr.fileno())
|
||||
|
||||
|
||||
@@ -21,6 +21,7 @@
|
||||
|
||||
import os
|
||||
import sys
|
||||
import tempfile
|
||||
from collections.abc import Callable
|
||||
from typing import Any, ClassVar
|
||||
|
||||
@@ -884,14 +885,8 @@ class Win32Implementation(BaseImplementation):
|
||||
# No custom icons present, fall back to default icons
|
||||
ico_buffer = self._load_ico_buffer(icon_name, icon_size)
|
||||
|
||||
try:
|
||||
import tempfile
|
||||
|
||||
file_handle = tempfile.NamedTemporaryFile(delete=False)
|
||||
|
||||
with file_handle:
|
||||
file_handle.write(ico_buffer)
|
||||
|
||||
with tempfile.NamedTemporaryFile(delete=False) as file_handle:
|
||||
file_handle.write(ico_buffer)
|
||||
return windll.user32.LoadImageA(
|
||||
0,
|
||||
encode_path(file_handle.name),
|
||||
@@ -901,9 +896,6 @@ class Win32Implementation(BaseImplementation):
|
||||
self.LR_LOADFROMFILE,
|
||||
)
|
||||
|
||||
finally:
|
||||
os.remove(file_handle.name)
|
||||
|
||||
def _destroy_h_icon(self):
|
||||
from ctypes import windll
|
||||
|
||||
|
||||
@@ -279,7 +279,7 @@ class VMObject(GObject.Object):
|
||||
|
||||
if not self._log_file:
|
||||
try:
|
||||
self._log_file = open(proc.out_file) # noqa: SIM115
|
||||
self._log_file = Path(proc.out_file).open() # noqa: SIM115
|
||||
except Exception as ex:
|
||||
log.exception(ex)
|
||||
self._log_file = None
|
||||
|
||||
Reference in New Issue
Block a user