feat(inventory/instances): dont set module location to allow underlying error location to bubble up

This commit is contained in:
Johannes Kirschbauer
2025-04-08 13:10:26 +02:00
parent 5db084e011
commit 375b18fd32

View File

@@ -120,22 +120,9 @@ let
}
```
*/
makeExtensibleConfig =
f: args:
let
makeModuleExtensible =
eval:
eval.config
// {
__functor = _self: m: makeModuleExtensible (eval.extendModules { modules = lib.toList m; });
};
in
makeModuleExtensible (f args);
# Extend evalModules result by a module, returns .config.
extendEval =
eval: m:
(eval.extendModules { modules = lib.toList m; } ).config;
extendEval = eval: m: (eval.extendModules { modules = lib.toList m; }).config;
/**
Apply the settings to the instance
@@ -151,20 +138,18 @@ let
machines = lib.mapAttrs (machineName: v: {
# TODO: evaluate the settings against the interface
# settings = (evalMachineSettings { inherit roleName instanceName; inherit (v) settings; }).config;
settings = (
evalMachineSettings {
settings =
(evalMachineSettings {
inherit roleName instanceName machineName;
inherit (v) settings;
}
).config;
}).config;
}) role.machines;
# TODO: evaluate the settings against the interface
settings = (
evalMachineSettings {
settings =
(evalMachineSettings {
inherit roleName instanceName;
inherit (role) settings;
}
).config;
}).config;
}) instance.roles;
in
{
@@ -332,20 +317,17 @@ in
name = machineName;
roles = lib.attrNames (lib.filterAttrs (_n: v: v.machines ? ${machineName}) roles);
};
settings = (
evalMachineSettings {
settings =
(evalMachineSettings {
inherit roleName instanceName machineName;
settings =
config.instances.${instanceName}.roles.${roleName}.machines.${machineName}.settings or { };
}
).config;
extendSettings = extendEval (
evalMachineSettings {
}).config;
extendSettings = extendEval (evalMachineSettings {
inherit roleName instanceName machineName;
settings =
config.instances.${instanceName}.roles.${roleName}.machines.${machineName}.settings or { };
}
);
});
};
modules = [ v ];
}).config;
@@ -521,7 +503,8 @@ in
imports = [
# For error backtracing. This module was produced by the 'perMachine' function
# TODO: check if we need this or if it leads to better errors if we pass the underlying module locations
(lib.setDefaultModuleLocation "clan.service: ${config.manifest.name} - via perMachine" machineResult.nixosModule)
# (lib.setDefaultModuleLocation "clan.service: ${config.manifest.name} - via perMachine" machineResult.nixosModule)
(machineResult.nixosModule)
] ++ instanceResults;
};
}