Merge pull request 'better nixos defaults' (#2106) from better-defaults into main

nixosModules/clanCore/default.nix

@@ -1,3 +1,4 @@
+{ lib, config, ... }:
 {
   imports = [
     ./backups.nix
@@ -18,5 +19,17 @@
     ./vm.nix
     ./wayland-proxy-virtwl.nix
     ./zerotier
+    ./zfs.nix
   ];
+
+  # Use systemd during boot as well except:
+  # - systems with raids as this currently require manual configuration: https://github.com/NixOS/nixpkgs/issues/210210
+  # - for containers we currently rely on the `stage-2` init script that sets up our /etc
+  boot.initrd.systemd.enable = lib.mkDefault (!config.boot.swraid.enable && !config.boot.isContainer);
+
+  # Work around for https://github.com/NixOS/nixpkgs/issues/124215
+  documentation.info.enable = lib.mkDefault false;
+
+  # Don't install the /lib/ld-linux.so.2 stub. This saves one instance of nixpkgs.
+  environment.ldso32 = null;
 }

nixosModules/clanCore/zfs.nix

@@ -0,0 +1,16 @@
+{ lib, config, ... }:
+{
+  # Use the same default hostID as the NixOS install ISO and nixos-anywhere.
+  # This allows us to import zfs pool without using a force import.
+  # ZFS has this as a safety mechanism for networked block storage (ISCSI), but
+  # in practice we found it causes more breakages like unbootable machines,
+  # while people using ZFS on ISCSI is quite rare.
+  networking.hostId = lib.mkDefault "8425e349";
+
+  services.zfs = lib.mkIf (config.boot.zfs.enabled) {
+    autoSnapshot.enable = true;
+    # defaults to 12, which is a bit much given how much data is written
+    autoSnapshot.monthly = lib.mkDefault 1;
+    autoScrub.enable = true;
+  };
+}