Merge pull request 'machines update: support --target-host localhost' (#4623) from jfly/clan-core:localhost-as-target-host-without-ssh into main

Reviewed-on: https://git.clan.lol/clan/clan-core/pulls/4623

pkgs/clan-cli/clan_cli/machines/update.py

@@ -144,10 +144,14 @@ def update_command(args: argparse.Namespace) -> None:
                     build_host = machine.build_host()
                 # Figure out the target host
                 if args.target_host:
-                    target_host = Remote.from_ssh_uri(
-                        machine_name=machine.name,
-                        address=args.target_host,
-                    ).override(host_key_check=host_key_check)
+                    target_host: Host | None = None
+                    if args.target_host == "localhost":
+                        target_host = LocalHost()
+                    else:
+                        target_host = Remote.from_ssh_uri(
+                            machine_name=machine.name,
+                            address=args.target_host,
+                        ).override(host_key_check=host_key_check)
                 else:
                     target_host = machine.target_host().override(
                         host_key_check=host_key_check

pkgs/clan-cli/clan_lib/ssh/localhost.py

@@ -18,7 +18,7 @@ class LocalHost:
 
     command_prefix: str = "localhost"
     _user: str = field(default_factory=lambda: os.environ.get("USER", "root"))
-    _askpass_path: str | None = None
+    _sudo: bool = False
 
     @property
     def target(self) -> str:
@@ -52,11 +52,10 @@ class LocalHost:
             env.update(extra_env)
 
         # Handle sudo if needed
-        if self._askpass_path is not None:
+        if self._sudo:
             # Prepend sudo command
             sudo_cmd = ["sudo", "-A", "--"]
             cmd = sudo_cmd + cmd
-            env["SUDO_ASKPASS"] = self._askpass_path
 
         # Set options
         opts.env = env
@@ -85,9 +84,8 @@ class LocalHost:
             yield self
             return
 
-        # For local execution, we can use sudo with askpass if GUI is available
-        # This is a simplified version - could be enhanced with sudo askpass proxy
-        yield self
+        # This is a simplified version - could be enhanced with sudo askpass proxy.
+        yield LocalHost(_sudo=True)
 
     @contextmanager
     def host_connection(self) -> Iterator["LocalHost"]: