yadunut/clan-core
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

do not instantiate vars_generators several times

Browse Source 
We should really not have any property that has side effects i.e.
spawning processes.
This commit is contained in:
Jörg Thalheim
2025-05-14 09:09:40 +02:00
parent d397c8ad39
commit 1ff5d64a78
9 changed files with 25 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pkgs/clan-cli/clan_cli/vars/generate.py
View File

@@ -132,7 +132,7 @@ def decrypt_dependencies(
decrypted_dependencies: dict[str, Any] = {}
for generator_name in set(generator.dependencies):
decrypted_dependencies[generator_name] = {}
for dep_generator in machine.vars_generators:
for dep_generator in machine.vars_generators():
if generator_name == dep_generator.name:
break
else:
@@ -320,7 +320,7 @@ def get_closure(
) -> list[Generator]:
from .graph import all_missing_closure, full_closure
vars_generators = machine.vars_generators
vars_generators = machine.vars_generators()
generators: dict[str, Generator] = {
generator.name: generator for generator in vars_generators
}
@@ -399,7 +399,7 @@ def generate_vars_for_machine(
machine = Machine(name=machine_name, flake=Flake(str(base_dir)))
generators_set = set(generators)
generators_ = [g for g in machine.vars_generators if g.name in generators_set]
generators_ = [g for g in machine.vars_generators() if g.name in generators_set]
return _generate_vars_for_machine(
machine=machine,
@@ -417,7 +417,7 @@ def generate_vars_for_machine_interactive(
) -> bool:
_generator = None
if generator_name:
for generator in machine.vars_generators:
for generator in machine.vars_generators():
if generator.name == generator_name:
_generator = generator
break