Fixing deadlock
This commit is contained in:
@@ -21,7 +21,6 @@ class Command:
|
|||||||
stdout: _FILE = None,
|
stdout: _FILE = None,
|
||||||
stderr: _FILE = None,
|
stderr: _FILE = None,
|
||||||
workdir: Optional[Path] = None,
|
workdir: Optional[Path] = None,
|
||||||
check: Optional[bool] = True,
|
|
||||||
) -> subprocess.Popen[str]:
|
) -> subprocess.Popen[str]:
|
||||||
env = os.environ.copy()
|
env = os.environ.copy()
|
||||||
env.update(extra_env)
|
env.update(extra_env)
|
||||||
@@ -37,14 +36,6 @@ class Command:
|
|||||||
cwd=workdir,
|
cwd=workdir,
|
||||||
)
|
)
|
||||||
self.processes.append(p)
|
self.processes.append(p)
|
||||||
if check:
|
|
||||||
p.wait()
|
|
||||||
if p.returncode != 0:
|
|
||||||
aout = p.stdout.read() if p.stdout else ""
|
|
||||||
bout = p.stderr.read() if p.stderr else ""
|
|
||||||
raise subprocess.CalledProcessError(
|
|
||||||
p.returncode, command, output=aout, stderr=bout
|
|
||||||
)
|
|
||||||
return p
|
return p
|
||||||
|
|
||||||
def terminate(self) -> None:
|
def terminate(self) -> None:
|
||||||
|
|||||||
Reference in New Issue
Block a user