yadunut/clan-core
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

chore: add todo comments for template logic in create machine

Browse Source
This commit is contained in:
Johannes Kirschbauer
2025-05-26 16:05:20 +02:00
parent fe933d8eb7
commit 14701fda01
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
pkgs/clan-cli/clan_cli/machines/create.py
View File

@@ -51,6 +51,9 @@ def create_machine(opts: CreateOptions, commit: bool = True) -> None:
clan_dir = opts.clan_dir.path clan_dir = opts.clan_dir.path
# TODO(@Qubasa): make this a proper template handler
# i.e. with_template (use context manager)
# And move the checks and template handling into the template handler
template = get_template( template = get_template(
TemplateName(opts.template_name), TemplateName(opts.template_name),
"machine", "machine",
@@ -64,10 +67,7 @@ def create_machine(opts: CreateOptions, commit: bool = True) -> None:
Flake(str(clan_dir)) Flake(str(clan_dir))
) and not opts.machine.get("name"): ) and not opts.machine.get("name"):
msg = f"{opts.template_name} is already defined in {clan_dir}" msg = f"{opts.template_name} is already defined in {clan_dir}"
description = ( raise ClanError(msg)
"Please add the --rename option to import the machine with a different name"
)
raise ClanError(msg, description=description)
machine_name = machine_name if machine_name else opts.template_name machine_name = machine_name if machine_name else opts.template_name
src = Path(template.src["path"]) src = Path(template.src["path"])
@@ -92,15 +92,17 @@ def create_machine(opts: CreateOptions, commit: bool = True) -> None:
if dst.exists(): if dst.exists():
msg = f"Machine {machine_name} already exists in {clan_dir}" msg = f"Machine {machine_name} already exists in {clan_dir}"
description = ( description = (
"Please delete the existing machine or import with a different name" "Please remove the existing machine folder"
) )
raise ClanError(msg, description=description) raise ClanError(msg, description=description)
# TODO(@Qubasa): move this into the template handler
if not (src / "configuration.nix").exists(): if not (src / "configuration.nix").exists():
msg = f"Template machine '{opts.template_name}' does not contain a configuration.nix" msg = f"Template machine '{opts.template_name}' does not contain a configuration.nix"
description = "Template machine must contain a configuration.nix" description = "Template machine must contain a configuration.nix"
raise ClanError(msg, description=description) raise ClanError(msg, description=description)
# TODO(@Qubasa): move this into the template handler
copy_from_nixstore(src, dst) copy_from_nixstore(src, dst)
target_host = opts.target_host target_host = opts.target_host