S108: ignore our uses
This commit is contained in:
@@ -176,7 +176,7 @@ class ClanFlake:
|
||||
self.temporary_home = temporary_home
|
||||
self.path = temporary_home / "flake"
|
||||
if not suppress_tmp_home_warning:
|
||||
if "/tmp" not in str(os.environ.get("HOME")):
|
||||
if "/tmp" not in str(os.environ.get("HOME")): # noqa: S108 - Checking if HOME is in temp directory
|
||||
log.warning(
|
||||
f"!! $HOME does not point to a temp directory!! HOME={os.environ['HOME']}",
|
||||
)
|
||||
@@ -368,7 +368,7 @@ def create_flake(
|
||||
check=True,
|
||||
)
|
||||
|
||||
if "/tmp" not in str(os.environ.get("HOME")):
|
||||
if "/tmp" not in str(os.environ.get("HOME")): # noqa: S108 - Checking if HOME is in temp directory
|
||||
log.warning(
|
||||
f"!! $HOME does not point to a temp directory!! HOME={os.environ['HOME']}",
|
||||
)
|
||||
|
||||
@@ -14,7 +14,7 @@ TEMPDIR = None
|
||||
# macOS' default temporary directory is too long for unix sockets
|
||||
# This can break applications such as gpg-agent
|
||||
if platform == "darwin":
|
||||
TEMPDIR = Path("/tmp")
|
||||
TEMPDIR = Path("/tmp") # noqa: S108 - Required on macOS due to socket path length limits
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
|
||||
@@ -13,7 +13,7 @@ def test_get_clan_details_invalid_flake() -> None:
|
||||
get_clan_details(invalid_flake)
|
||||
|
||||
with pytest.raises(FlakeInvalidError):
|
||||
get_clan_details(Flake("/tmp"))
|
||||
get_clan_details(Flake("/tmp")) # noqa: S108
|
||||
|
||||
|
||||
@pytest.mark.with_core
|
||||
|
||||
@@ -139,7 +139,7 @@ class Remote:
|
||||
if sys.platform == "darwin" and os.environ.get("TMPDIR", "").startswith(
|
||||
"/var/folders/",
|
||||
):
|
||||
directory = "/tmp/"
|
||||
directory = "/tmp/" # noqa: S108 - Required on macOS due to bugs with default TMPDIR
|
||||
with TemporaryDirectory(prefix="clan-ssh", dir=directory) as temp_dir:
|
||||
remote = Remote(
|
||||
address=self.address,
|
||||
|
||||
@@ -33,7 +33,7 @@ def upload(
|
||||
# Exceptions: Allow depth 2 if the path starts with /tmp/, /root/, or /etc/.
|
||||
# This allows destinations like /tmp/mydir or /etc/conf.d, but not /tmp or /etc directly.
|
||||
is_allowed_exception = depth >= 2 and (
|
||||
str(remote_dest).startswith("/tmp/")
|
||||
str(remote_dest).startswith("/tmp/") # noqa: S108 - Path validation check
|
||||
or str(remote_dest).startswith("/root/")
|
||||
or str(remote_dest).startswith("/etc/")
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user